[Pidgin] #48: Make SIP/SIMPLE work with Microsoft Live Communication Server

[Pidgin]

#48: Make SIP/SIMPLE work with Microsoft Live Communication Server
---------------------------+------------------------------------------------
 Reporter:  MarkDoliner    |        Owner:  shulman
     Type:  patch          |       Status:  new    
Milestone:                 |    Component:  SIMPLE 
  Version:  2.0            |   Resolution:         
 Keywords:  MS LCS SIMPLE  |  
---------------------------+------------------------------------------------

Comment(by fixxxer):

 Replying to [comment:220 gburt]:

 > > Also, the below part was because I sometimes I got another value
 different to 'busy','away','avalaible', then pidgin doesn't put a correct
 status to the almost all contacts (inclusive doesn't put the 'avalaible')
 >
 > If you got a value other than 'busy' or 'away' then it should have been
 assuming a status_id of 'available'.  Are you saying that wasn't
 happening?

 Yes, I'm saying that :D [[BR]]
 You had this:
 {{{
                 gchar * status_id;
                 if (activity) {
                         if (strstr(activity, "busy")) {
                                 status_id = "busy";
                         } else if (strstr(activity, "away")) {
                                 status_id = "away";
                         }
                 }

                 if (!status_id) {
                         status_id = "available";
                 }

 }}}

 But my problem is when activity has a true value but status_id has a
 garbage value like this '97B'. then I have this error on pidgin:

 {{{
 (12:34:07) sipe: process_incoming_notify: basic-status(open)
 (12:34:07) sipe: process_incoming_notify: activity(available)
 (12:34:07) sipe: process_incoming_notify: status_id(97B)
 (12:34:07) g_log: purple_status_is_online: assertion `status != NULL'
 failed
 }}}

 For that I put the 'else' with status_id hardcoded. I don't know why
 status_id in not null.

 Or may be will be better this:

 {{{
 gchar * status_id = NULL;
 }}}

 I proved it and works fine too. I will change it with this in the next
 commit.

 Regards.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/48#comment:224>
Pidgin <http://pidgin.im>
Pidgin