[Pidgin] #3319: MSN group name display support

[Pidgin]

#3319: MSN group name display support
-----------------------+----------------------------------------------------
 Reporter:  manphiz    |        Owner:  khc
     Type:  patch      |       Status:  new
Milestone:             |    Component:  MSN
  Version:  2.2.0      |   Resolution:     
 Keywords:  msn group  |  
-----------------------+----------------------------------------------------

Comment(by felipec):

 Replying to [comment:34 SuperMMX]:
 > Replying to [comment:33 felipec]:
 > >
 > > I'm talking about the patch. The patch is not per conversation.
 > >
 > > msn_group_member_nick2.diff is adding a 'special_alias' field for a
 buddy, so a buddy can't have a different one in another conversation.
 >
 > I know it is some kind of hack, but currently there is no other better
 ways to implement it, so I store such information in the buddy structure.
 See my [comment:17 comment] for a better solution (encapsulating all the
 necessary parameters into a structure, like PurpleMessage).

 Temporary hacks that mess with libpurple core are bad. If I was a
 libpurple dev I wouldn't merge your patch until it's done properly.

 > And I don't understand the meaning of another conversation here. Why a
 user has more than one conversation with the same buddy ?

 Two group chats, with different people, the same buddy is in both. Or you
 have a group chat with your buddy there, and also IM.

 > > And sure, in the official client you don't see who sent the message,
 but that's a disadvantage of the UI, the protocol is using the passport
 all the time.
 >
 > The debug message looks like this:
 > {{{
 > (19:05:38) msn: Message SB RECV:
 > {MIME-Version: 1.0
 >
 > Content-Type: text/plain; charset=UTF-8
 >
 > P4-Context: TestName
 >
 > X-MMS-IM-Format: FN=SimSun; EF=; CO=0; CS=86; PF=0
 >
 > ok
 > }
 > }}}
 >
 > Where is the passport of the actual message sender ? I didn't see it.

 I wrote the code to display that debugging message, I didn't think adding
 the passport was necessary, so what?

 Look at what's sent over the wire:
 http://www.hypothetic.org/docs/msn/switchboard/messages.php

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3319#comment:38>
Pidgin <http://pidgin.im>
Pidgin