[Pidgin] #5223: Pidgin disconnects from Yahoo! Chat with Unknown error number 0. (regression)

[Pidgin]

#5223: Pidgin disconnects from Yahoo! Chat with Unknown error number 0.
(regression)
----------------------------+-----------------------------------------------
 Reporter:  Karmadon        |        Owner:  marv       
     Type:  defect          |       Status:  closed     
Milestone:                  |    Component:  Yahoo!     
  Version:  2.5.1           |   Resolution:  out of date
 Keywords:  error number 0  |  
----------------------------+-----------------------------------------------

Comment(by markdoliner at pidgin.im):

 (In [97d295a04f3a9852a3b29cf0df43d56d1ddcc672]):[[BR]]
 Two functional changes here:
 1. The default error case for unknown errors on yahoo now uses
    PURPLE_CONNECTION_ERROR_OTHER_ERROR instead of
    PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED.  This change was
    made because it's logical.
 2. The unknown yahoo error with error code "0" now uses
    PURPLE_CONNECTION_ERROR_NETWORK_ERROR instead of
    PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED.  This change was
    made because this error doesn't seem to be fatal, and we want the
    account to be reconnected, but normally AUTHENTICATION_FAILED
    errors are fatal and should not be reconnected

 Specially this makes yahoo accounts auto-reconnect when we get the error
 "Unknown error number 0. Logging into the Yahoo! website may fix this."
 I know we think we fixed this with that change to send the timeout or
 keepalive much less often, but I'm still seeing a lot of disconnects for
 it and I have a strong suspicion that they're not actually fatal errors.

 Refs #5223

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5223#comment:27>
Pidgin <http://pidgin.im>
Pidgin