[Pidgin] #7712: Nullprpl cleanup/fixes

[Pidgin]

#7712: Nullprpl cleanup/fixes
---------------------------+------------------------------------------------
 Reporter:  darkrain42     |        Owner:           
     Type:  patch          |       Status:  new      
Milestone:                 |    Component:  libpurple
  Version:  2.5.2          |   Resolution:           
 Keywords:  null nullprpl  |  
---------------------------+------------------------------------------------
Description changed by darkrain42:

Old description:

> Various nullprpl fixes. This stemmed from a complaint from a user in
> #pidgin that it crashed if the user didn't change the room from "default"
> to something else when joining.
>
> Nothing big here, but here's the list:
>  * Make a bunch of strings const for good measure
>  * g_strdup strings that the caller is supposed to be freeing (one of
> these almost certainly fixes the aforementioned crash)
>  * Use g_list_prepend/g_list_reverse
>  * Don't leak some strings
>  * g_* needs g_free, not free (this might also be the one fixing the
> crash)

New description:

 Various nullprpl fixes. This stemmed from a complaint from a user in
 #pidgin that it crashed if the user didn't change the room from "default"
 to something else when joining a chat.

 Nothing big here, but here's the list:
  * Make a bunch of strings const for good measure
  * g_strdup strings that the caller is supposed to be freeing (one of
 these almost certainly fixes the aforementioned crash)
  * Use g_list_prepend/g_list_reverse
  * Don't leak some strings
  * g_* needs g_free, not free (this might also be the one fixing the
 crash)

--

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7712#comment:1>
Pidgin <http://pidgin.im>
Pidgin