[Pidgin] #7734: XMPP avatar code calculating wrong checksum

Pidgin trac at pidgin.im
Tue Dec 9 19:36:05 EST 2008


#7734: XMPP avatar code calculating wrong checksum
------------------------+---------------------------------------------------
 Reporter:  darkrain42  |        Owner:  deryni
     Type:  patch       |       Status:  new   
Milestone:              |    Component:  XMPP  
  Version:  2.5.2       |   Resolution:        
 Keywords:              |  
------------------------+---------------------------------------------------

Comment(by darkrain42):

 Updated the patch (again) so that it applies on top of #7732 (otherwise I
 believe it requires {{{ -F3 }}}).

 Added a second patch that changes what the prpl does on login to reduce
 bandwidth consumption. The current sha1 hash of the avatar is stored in
 the account settings. At login, after attempting to retrieve the vcard,
 only update the vcard on-server if either there is no vcard on the server
 or our icon is different. When updating the icon in our vcard at startup,
 no longer also always update the User Avatar (XEP-0084) version of the
 icon.

 In terms of bandwidth, before applying the second patch, signing on
 causing the vcard to be retrieved from and then sent to the server once
 each plus our avatar sent to the server (plus returned in the <iq
 type='result'>) twice (since #7732 now sets the icon in both XEP-0084
 namespaces).

 After applying it, if the server-side vcard and avatar are up-to-date, we
 only retrieve our vcard.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7734#comment:3>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list