[Pidgin] #7687: Perl Purple::Prefs::add_string_list drops the last item when initializing

Pidgin trac at pidgin.im
Thu Dec 11 12:24:18 EST 2008


#7687: Perl Purple::Prefs::add_string_list drops the last item when initializing
---------------------+------------------------------------------------------
 Reporter:  samwyse  |        Owner:         
     Type:  patch    |       Status:  closed 
Milestone:  2.5.3    |    Component:  plugins
  Version:  2.5.2    |   Resolution:  fixed  
 Keywords:           |  
---------------------+------------------------------------------------------

Comment(by darkrain42):

 Having had sleep, I still believe my comments to rekkanoryo last night
 were correct (put here so I don't have to rely on my memory):
 {{{
 (00:51:35) darkrain42: For a995956b, I'm pretty sure it should have been
 my patch *or* etan's suggestion, but not both (I'm pretty exhausted, so
 I'm not 100% I'm thinking straight)
 (00:51:46) darkrain42: (that's the perl loop iteration one)
 (00:52:31) darkrain42: I'm not going to demand you fix it now, but I
 thought I should mention it before I forgot
 (00:53:45) rekkanoryo: hmm, ok, I must be a bit too tired myself
 (00:54:38) rekkanoryo: I'll leave it for now and fix it after I've had
 some sleep (which means friday at the earliest), unless someone wants to
 beat me to disapproving one of those two revisions
 }}}

 This references a995956b and 0538a6873b (and to clarify, my thinking is
 that now it goes one element past the end of the list)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7687#comment:7>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list