[Pidgin] #5681: infinite input area auto resizing, pidgin hangs.

Pidgin trac at pidgin.im
Sat Dec 13 23:54:22 EST 2008


#5681: infinite input area auto resizing, pidgin hangs.
---------------------+------------------------------------------------------
 Reporter:  irtiger  |        Owner:  sadrul      
     Type:  patch    |       Status:  new         
Milestone:           |    Component:  pidgin (gtk)
  Version:  2.4.1    |   Resolution:              
 Keywords:           |  
---------------------+------------------------------------------------------

Comment(by tejun):

 Okay, here's updated patch against 2.5.2.  Several things to note...

 1. The infinite-resize bug doesn't exist anymore even w/o the patch.  The
 new gtk_text_view_get_line_yrange() based implementation seems to work
 fine.  I still think asking gtk about the widget size is better/simpler
 approach except for the UNSUPPORTED_API stunt.  So, one pro and one con,
 the decision is up to you.

 2. In the above posted patch, I restored the original "diff == 0 && (diff
 < 0 && -diff < oneline.height / 2)" condition because the thing gotta grow
 whether the amount of growth is bigger than half a line or not and with
 the gtk telling us the true size of the widget, it should just work fine.
 I didn't go through the log, so if the ABS() check was added for some
 different reason, you might wanna drop that part.

 Thanks.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5681#comment:11>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list