[Pidgin] #479: Gaim 2.0.0beta6 - Jabber contact list one contact repeated

[Pidgin]

#479: Gaim 2.0.0beta6 - Jabber contact list one contact repeated
---------------------------------+------------------------------------------
 Reporter:  cga                  |        Owner:  deryni
     Type:  patch                |       Status:  new   
Milestone:  2.5.4                |    Component:  XMPP  
  Version:  2.0                  |   Resolution:        
 Keywords:  jabber contact list  |  
---------------------------------+------------------------------------------

Comment(by darkrain42):

 Replying to [comment:39 schubert]:
 > I have tried the new patch but I still have the same duplicate buddy
 issue with jabber in the scenario I described earlier:
 >
 > A and B have each other in their buddy lists.
 >
 > 1) A removes B from A's buddy list.[[BR]]
 > 2) Without B making any changes, A adds B back to A's buddy list,
 causing an authorization request to be sent to B.[[BR]]
 > 3) B accepts the authorization request from A, but then is presented
 with the "Add Buddy" window.[[BR]]
 > 4) If B now adds A, there will be two copies of A on B's list, since B
 never removed the initial instance. If B does not add A, the authorization
 will not go through.

 You're correct; it doesn't work properly if, in step 4, the not-authorized
 copy of the buddy is in the "Buddies" group and you do not specify a group
 in which to add the buddy. The code in libpurple will default this to
 "Buddies", but the gtkblist.c checks in my patch won't find that existing
 PurpleBuddy ( {{{ purple_find_buddy_in_group(account, who, group == "" or
 group == NULL) }}} will return NULL).

 I attached an updated patch that will re-use any existing PurpleBuddy if
 no group was specified, which should work.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/479#comment:40>
Pidgin <http://pidgin.im>
Pidgin