[Pidgin] #7920: Bonjour on Win32 Crash

[Pidgin]

#7920: Bonjour on Win32 Crash
---------------------------+------------------------------------------------
 Reporter:  BigBrownChunx  |     Owner:  datallah
     Type:  patch          |    Status:  new     
Component:  Bonjour        |   Version:  2.5.3   
 Keywords:  bonjour crash  |  
---------------------------+------------------------------------------------
 I am often experiencing crashes in _mdns_resolve_host_callback() in
 mdns_win32.c when buddies go offline.  This is due to the lack of error
 checking in the callback.

 args->bb->name can be NULL when buddies go offline (beats me why), and
 this causes crashes in the debug printout, since win32 glib can't handle
 printing NULL strings without segfaulting.

 I'm not sure if this is the best way to handle it, or if its part of a
 larger problem but a partial solution for me has been to add

 g_return_if_fail(args->bb->name != NULL);
 to line 172 of mdns_win32.c

 There is still some problems with free'd memory being passed to the
 callback, but this needs further investigation.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7920>
Pidgin <http://pidgin.im>
Pidgin