[Pidgin] #4790: myspace protocol performance improvement
Pidgin
trac at pidgin.im
Wed Feb 6 21:31:51 EST 2008
#4790: myspace protocol performance improvement
-------------------+--------------------------------------------------------
Reporter: oliver | Owner: jeff
Type: patch | Status: new
Priority: minor | Component: MySpace
Version: 2.3.1 | Keywords:
Pending: 0 |
-------------------+--------------------------------------------------------
In message.c in the escape & unescape functions the loops are not optimal,
doing a strlen() for each character in the message string. [[BR]]
valgrind/callgrind identified especially msim_unescape() as a expensive
because of that (guess there is more unescaping going on than
escaping).[[BR]]
The attached patch moves the strlen() out of the loop header for both
functions.
--
Ticket URL: <http://developer.pidgin.im/ticket/4790>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list