[Pidgin] #4796: Transactions are reused for authentication instead of creating new ones

[Pidgin]

#4796: Transactions are reused for authentication instead of creating new ones
----------------------+-----------------------------------------------------
Reporter:  pchitescu  |       Owner:  seanegan       
    Type:  defect     |      Status:  new            
Priority:  minor      |   Component:  SIMPLE         
 Version:  2.3.1      |    Keywords:  sip transaction
 Pending:  0          |  
----------------------+-----------------------------------------------------
 While trying to connect with pidgin to a [http://yate.null.ro] server I
 noticed with Wireshark that existing MESSAGE, SUBSCRIBE, etc. packets are
 just added an authentication line and retransmitted with the same other
 headers.[[BR]]
 This behaviour is wrong. The SIP transaction is finished at that point and
 a new one '''must''' be created. At least the Via branch and CSeq number
 must change besides adding the Authorization header so it becomes a new
 transaction. These transactions are best handled separately - it is
 perfectly possible a retransmission for the initial (unauthenticated,
 challenged) transaction is received while the new one is still unanswered.
 If both proxy and UAS authentication is used then even more transactions
 are required.[[BR]]
 Moreover, when shutting down or disabling the account if the REGISTER is
 challenged no new message is generated. If UDP is used for transport the
 deregistration will occur only at expire time.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4796>
Pidgin <http://pidgin.im>
Pidgin