[Pidgin] #1187: Send Custom Emoticons in MSN

[Pidgin]

#1187: Send Custom Emoticons in MSN
-----------------------+----------------------------------------------------
  Reporter:  salinasv  |       Owner:  khc  
      Type:  patch     |      Status:  new  
  Priority:  minor     |   Milestone:  2.4.0
 Component:  MSN       |     Version:  2.0  
Resolution:            |    Keywords:       
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by ebiederm):

 I just played with this and got these patches to work against 2.3.1 and
 msnp9  I just fixed the obvious patch rejects so nothing big going on
 there.  2.3.1 crashed horribly when I compiled out
 msnp9 so I could use msnp14 so I skipped that.

 In then generic custom emoticon support you probably don't want to allow
 the user to past in
 custom emoticons when the protocol does not support it.  It was very
 confusing when I was using
 msnp9 and pasting things and I didn't have a clue why it wasn't working.
 Having them greyed out
 or otherwise disabled is probably desireable.

 When I add a new smiley I can see it in the smiley dialog but can not use
 it in any conversations that predate when the smiley was added.  I did not
 test extensively so it may just be the data entry text box with that
 limitation.

 On a related note I can not seem to capture and save smileys when they are
 sent to me in conversation.  Making custom smileys a little harder to use.

 Does it may any sense for the generic support to convert this into an
 inline image transfer for the protocols that support that and not custom
 smileys.


 Anyway it looks good and I look forward to seeing the support merged in
 the next version of pidgin.  Thanks for all of your hard work.

 Eric

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1187#comment:102>
Pidgin <http://pidgin.im>
Pidgin