[Pidgin] #4816: ocar protocol performance improvement(s)
Pidgin
trac at pidgin.im
Sun Feb 10 16:47:17 EST 2008
#4816: ocar protocol performance improvement(s)
---------------------+------------------------------------------------------
Reporter: oliver | Owner: MarkDoliner
Type: patch | Status: closed
Priority: minor | Milestone: 2.3.2
Component: AIM | Version: 2.3.1
Resolution: fixed | Keywords: oscar performance patch
Pending: 0 |
---------------------+------------------------------------------------------
Comment (by oliver):
Replying to [comment:1 MarkDoliner]:
> I committed this change, thanks.
>
> My personal preference is for using a GHashTable ...
Yeah, definitely, but that would be a pretty big change. All the aim_ssi_*
routines would have their signatures change cause you'd need to pass the
hashtable.[[BR]]
I made a change to "struct aim_ssi_item" and added a key that i set to the
normalized string of name when it's added (or changed) so i don't have to
call aim_sncmp() each time it's looked up but i kept the linear
search.[[BR]]
In the same way I could add a pointer to the hashtable to "struct
aim_ssi_item" but that's kind of a waste and a hack. [[BR]]
If you have suggestions where to put (and how to reference) the
hashtable(s), that'd be great.
--
Ticket URL: <http://developer.pidgin.im/ticket/4816#comment:5>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list