[Pidgin] #4844: [patch] update purple_prefs_* perl bindings

Pidgin trac at pidgin.im
Thu Feb 14 15:44:15 EST 2008


#4844: [patch] update purple_prefs_* perl bindings
----------------------+-----------------------------------------------------
  Reporter:  zdeqb    |       Owner:  deryni          
      Type:  patch    |      Status:  new             
  Priority:  minor    |   Milestone:                  
 Component:  plugins  |     Version:  2.3.1           
Resolution:           |    Keywords:  perl prefs patch
   Pending:  0        |  
----------------------+-----------------------------------------------------
Changes (by deryni):

  * owner:  => deryni

Comment:

 Cna you tell me why you used mXPUSH* functions for the first three
 arguments to the pref callback function but XPUSHs for the last one? Is
 there a reason you capture the return value of call_sv but then don't use
 it anywhere? Passing the result of g_strdup to a function expecting a
 const gchar * is going to leak memory (in
 purple_perl_prefs_connect_callback). Is SvREFCNT_dec enough to free up the
 result of newSVsv and purple_perl_bless_object? (It might be, I haven't
 looked at the perl stuff in a while so I don't remember offhand.)

 Thanks for the patch, I'll accept the patch once my comments/questions
 above are taken care of, I'd handle some of them but at the moment I don't
 have time to dig into it, so I would appreciate it if you could.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4844#comment:1>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list