[Pidgin] #4814: Crash if xmpp pong timeout fires after account is disconnected

[Pidgin]

#4814: Crash if xmpp pong timeout fires after account is disconnected
------------------------+---------------------------------------------------
  Reporter:  nosnilmot  |       Owner:  seanegan              
      Type:  defect     |      Status:  assigned              
  Priority:  minor      |   Milestone:  2.4.0                 
 Component:  XMPP       |     Version:                        
Resolution:             |    Keywords:  jabber xmpp ping crash
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by nosnilmot):

 Proof that checking for js != NULL in jabber_pong_timeout() would not
 work:
 {{{
 (gdb) bt
 #0  0x00110402 in __kernel_vsyscall ()
 #1  0x00515fa0 in raise () from /lib/libc.so.6
 #2  0x005178b1 in abort () from /lib/libc.so.6
 #3  0x080c1aba in sighandler (sig=11) at gtkmain.c:220
 #4  <signal handler called>
 #5  0x0128bf48 in jabber_pong_timeout (gc=0x9be36f0) at jabber.c:402
 #6  0x007e0dc6 in ?? () from /lib/libglib-2.0.so.0
 #7  0x007e07f2 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
 #8  0x007e37cf in ?? () from /lib/libglib-2.0.so.0
 #9  0x007e3b79 in g_main_loop_run () from /lib/libglib-2.0.so.0
 #10 0x0212df44 in IA__gtk_main () at gtkmain.c:1154
 #11 0x080c2a17 in main (argc=2, argv=0xbf9427d4) at gtkmain.c:886
 (gdb) frame 5
 #5  0x0128bf48 in jabber_pong_timeout (gc=0x9be36f0) at jabber.c:402
 402             js->keepalive_timeout = -1;
 (gdb) p js
 $1 = (JabberStream *) 0x19
 (gdb)
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4814#comment:2>
Pidgin <http://pidgin.im>
Pidgin