[Pidgin] #1187: Send Custom Emoticons in MSN

[Pidgin]

#1187: Send Custom Emoticons in MSN
-----------------------+----------------------------------------------------
  Reporter:  salinasv  |       Owner:  khc  
      Type:  patch     |      Status:  new  
  Priority:  minor     |   Milestone:  2.4.0
 Component:  MSN       |     Version:  2.0  
Resolution:            |    Keywords:       
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by sadrul):

 Since it looks like custom smileys are something we are going to support,
 at some stage, I am going to commit the patches to some branch to make it
 easier for the patch writers to update the patch in
 im.pidgin.pidgin.custom_smileys. If anyone objects, speak up.

 Note about the current patch (mostly to myself, but someone else can
 tackle the issues):
  * smileyAPI.patch: _image_checksum leaks in _image_filename
  * smiley.c and gtksmiley.c need to be added in po/POTFILES.in
  * smileyAPI.patch: fullpath leaks in _load_file
  * need to hide the internals of PurpleSmiley
  * msn.c: 'emoticons' (the return value of _emoticon_add) leaks
  * what's the purpose of the 'profile' tag?
  * change 'varName's to 'var_name' or 'varname' (only for consistency)
  * smileyAPI.patch: _load_file and _set_data_impl should be static.
  * pidgin.patch: pidgin_themes_smiley_themeize can't change the signature.
 perhaps a new function needs to deprecate the existing one.
  * Apply the change to exclude the copyright messages from the doxygen
 foo.
  * smileyAPI.patch: why is the change in
 util.c:purple_markup_unescape_entity required?
  * smileyAPI.patch: _new_from_data is probably a better name for
 _new_from_stream.
  * pidgin.patch: in _del_from_list, it probably should be
 {{{
                 list = g_slist_delete_link(gtk_smileys, list);
 }}}
  * pidgin.patch: rename gaim to Pidgin in gtksmiley.h

 The changes required for most of these are pretty trivial, and shouldn't
 really get in the way of committing the patch in the branch. But they
 definitely need to be addressed before it can be merged to
 im.pidgin.pidgin.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1187#comment:107>
Pidgin <http://pidgin.im>
Pidgin