[Pidgin] #4903: Duplicate ACK apparently received when using HTTP method causes crash

[Pidgin]

#4903: Duplicate ACK apparently received when using HTTP method causes crash
-------------------+--------------------------------------------------------
Reporter:  toote   |       Owner:  khc
    Type:  defect  |      Status:  new
Priority:  minor   |   Component:  MSN
 Version:  2.3.1   |    Keywords:     
 Pending:  0       |  
-------------------+--------------------------------------------------------
 pidgin run with:

  * MALLOC_CHECK_=2
  * -d

 Last 20 lines of debug log
 {{{
 #(16:14:20) msn: S: SB 003: MSG fernando.marso at kayote.com Fernando 537
 #(16:14:20) msn: C: SB 003: MSG 4 D 150
 #(16:14:20) msn: S: SB 003: MSG fernando.marso at kayote.com Fernando 767
 #(16:14:20) msn: C: SB 003: MSG 5 D 150
 #(16:14:20) msn: C: SB 003: MSG 6 D 552
 #(16:14:20) msn: S: SB 003: MSG fernando.marso at kayote.com Fernando 154
 #(16:14:20) msn: C: SB 003: MSG 7 D 150
 #(16:14:20) msn: S: SB 003: MSG fernando.marso at kayote.com Fernando 1352
 #(16:14:20) msn: S: SB 003: MSG fernando.marso at kayote.com Fernando 1352
 #(16:14:20) msn: S: SB 003: ACK 4
 #(16:14:21) msn: S: SB 003: MSG fernando.marso at kayote.com Fernando 246
 #(16:14:21) custom-smiley: pidgin_conv_custom_smiley_allocated(): got
 GdkPixbufAnimation 0x8723d20 for smiley 'gatopaj'
 #(16:14:21) gtkconv: About to close the smiley pixbuf
 #(16:14:21) msn: C: SB 003: MSG 8 D 150
 #(16:14:21) msn: S: SB 003: ACK 5
 #(16:14:21) msn: S: SB 003: ACK 6
 #(16:14:22) msn: S: SB 003: ACK 6
 }}}

 backtrace:


 {{{
 (gdb) bt full
 #0  0xffffe410 in __kernel_vsyscall ()
 No symbol table info available.
 #1  0xb7648f15 in raise () from /lib/i686/cmov/libc.so.6
 No symbol table info available.
 #2  0xb764a891 in abort () from /lib/i686/cmov/libc.so.6
 No symbol table info available.
 #3  0x080bbe5b in sighandler (sig=11) at ../../pidgin/gtkmain.c:220
 No locals.
 #4  <signal handler called>
 No symbol table info available.
 #5  0x00000019 in ?? ()
 No symbol table info available.
 #6  0xb6415d46 in ack_cmd (cmdproc=0x8dcbb30, cmd=0x8de1bd0) at
 ../../../../libpurple/protocols/msnp9/switchboard.c:771
         msg = (MsnMessage *) 0x8dd00a8
 #7  0xb6402018 in msn_cmdproc_process_cmd (cmdproc=0x8dcbb30,
 cmd=0x8de1bd0)
     at ../../../../libpurple/protocols/msnp9/cmdproc.c:313
         error_cb = <value optimized out>
         cb = (MsnTransCb) 0xb7768170
         trans = (MsnTransaction *) 0x8d68f58
 #8  0xb6402184 in msn_cmdproc_process_cmd_text (cmdproc=0x8dcbb30,
 command=0x8d03150 "ACK 6")
     at ../../../../libpurple/protocols/msnp9/cmdproc.c:335
 No locals.
 #9  0xb64050b4 in read_cb (data=0x8dcbb58, source=23,
 cond=PURPLE_INPUT_READ)
     at ../../../../libpurple/protocols/msnp9/httpconn.c:380
         httpconn = <value optimized out>
         buf = "ACK 6\r\n\000 200 OK\r\nDate: Fri, 22 Feb 2008 18:14:09
 GMT\r\nContent-Length: 7\r\nContent-Type: application/x-msn-messenger\r
 \nX-MSN-Messenger: SessionID=1420054865.1897490849; GW-IP=207.46.26.195\r
 \nX-MSN-Host: B"...
         end = 0x8d03157 ""
         len = <value optimized out>
         cur_len = <value optimized out>
         result_msg = 0x8d03150 "ACK 6"
         result_len = 7
 #10 0x080a3fa3 in pidgin_io_invoke (source=0x8d29500, condition=<value
 optimized out>, data=0x8db1b38)
     at ../../pidgin/gtkeventloop.c:78
         purple_cond = PURPLE_INPUT_READ
 #11 0xb780692d in ?? () from /usr/lib/libglib-2.0.so.0
 No symbol table info available.
 #12 0x08d29500 in ?? ()
 No symbol table info available.
 #13 0x00000001 in ?? ()
 No symbol table info available.
 #14 0x08db1b38 in ?? ()
 No symbol table info available.
 #15 0xb784837c in ?? () from /usr/lib/libglib-2.0.so.0
 No symbol table info available.
 ---Type <return> to continue, or q <return> to quit---
 #16 0xbff2d41c in ?? ()
 No symbol table info available.
 #17 0x08d75050 in ?? ()
 No symbol table info available.
 #18 0xbff2d438 in ?? ()
 No symbol table info available.
 #19 0xb77d72b6 in g_main_context_dispatch () from
 /usr/lib/libglib-2.0.so.0
 No symbol table info available.
 Backtrace stopped: frame did not save the PC
 (gdb)
 }}}

 per nosmilot request:

 {{{
 (gdb) frame 6
 #6  0xb6415d46 in ack_cmd (cmdproc=0x8dcbb30, cmd=0x8de1bd0)
     at ../../../../libpurple/protocols/msnp9/switchboard.c:771
 771     ../../../../libpurple/protocols/msnp9/switchboard.c: No such file
 or directory.
         in ../../../../libpurple/protocols/msnp9/switchboard.c
 (gdb) p *msg
 $1 = {ref_count = 1028671789, type = 775368754, msnslp_message =
 841889332,
   remote_user = 0x39312e36 <Address 0x39312e36 out of bounds>, flag = 53
 '5',
   content_type = 0x4e534d2d <Address 0x4e534d2d out of bounds>,
   charset = 0x736f482d <Address 0x736f482d out of bounds>,
   body = 0x42203a74 <Address 0x42203a74 out of bounds>, body_len =
 1397568089,
   msnslp_header = {session_id = 808530247, id = 909194292,
     offset = 7290890626896850222, total_size = 8319104456287676260,
     length = 1701277285, flags = 1768697458, ack_id = 1663985014,
     ack_sub_id = 168652143, ack_size = 5928236080373247320}, msnslp_footer
 = {
     value = 978470230}, attr_table = 0x32594220, attr_list = 0x3147534d,
   ack_ref = 875835441, cmd = 0xa0d3631, trans = 0x9f000a0d, ack_cb = 0x19,
   nak_cb = 0xb7768170, ack_data = 0xb7768170, error = MSN_MSG_ERROR_NONE}
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4903>
Pidgin <http://pidgin.im>
Pidgin