[Pidgin] #3208: Add support for ICQ6 status note

Pidgin trac at pidgin.im
Sat Jan 5 02:44:15 EST 2008

#3208: Add support for ICQ6 status note
  Reporter:  collin  |       Owner:  MarkDoliner
      Type:  patch   |      Status:  closed     
  Priority:  minor   |   Milestone:  2.3.2      
 Component:  ICQ     |     Version:  2.0.2      
Resolution:  fixed   |    Keywords:             
   Pending:  0       |  
Changes (by MarkDoliner):

  * status:  new => closed
  * resolution:  => fixed


 I committed this with some modifications.  Basically I'm super picky.

 Stripping HTML markup from info->status in oscar.c:purple_parse_oncoming()
 is not a valid thing to do.  The available message is a plain text field
 and does not contain HTML.  But I don't think that change is related to
 the status note changes, is it?

 I changed the indentation and commenting to be more similar to the
 existing code.

 I had already added a handler for
 slightly differently, so I used that and added in your
 aim_icq_getstatusnote() change.

 The family_icbm.c changes didn't compile because of IID and GUID aren't
 defined.  I worked around that by using a 32 bit int to represent the
 capability as is done elsewhere in the code, and used
 OSCAR_CAPABILITY_EMPTY to check if it was all zeros.

 I changed "for (;;)" in family_icq.c to parse out the info using a tlv
 list, as is done elsewhere in the oscar prpl.

 I don't like using a dummy while loop in family_icbm.c to allow breaking
 out of the current flow... it makes the logic different from other places
 in the oscar prpl, and I think I might try to change that.

 Also, I think it would be good if we could find a way to show both the
 status message and the status note.  Maybe show them in the tooltip.  Or
 the get info box.

 But other than those things, nice job getting this working.  Sorry it took
 me so long to get to it.  I hope you'll keep submitting patches to us.

Ticket URL: <http://developer.pidgin.im/ticket/3208#comment:8>
Pidgin <http://pidgin.im>

More information about the Tracker mailing list