[Pidgin] #4533: file transfer support for yahoo

Pidgin trac at pidgin.im
Sat Jan 5 22:00:31 EST 2008

#4533: file transfer support for yahoo
  Reporter:  madthanu   |       Owner:               
      Type:  patch      |      Status:  new          
  Priority:  minor      |   Milestone:               
 Component:  libpurple  |     Version:  2.3.1        
Resolution:             |    Keywords:  file transfer
   Pending:  0          |  
Comment (by madthanu):

 Replying to [comment:30 rekkanoryo]:
 > Generally, we use tab indents instead of spaces (although I would
 personally prefer a four-space indent over tabs).  I didn't look closely
 enough to see if that's an issue in your patch.  It's also easier to read
 patches and the resulting code if assignments have spaces around the =
 operator, like so:
 > {{{
 > #!c
 >         GList *bar = NULL;
 > }}}
 > Meaningful variable names are also great, but long names can be a pain
 at times (`yahoo_xfer_idstring_between_peers_xfer_map`, for example).
 They generally aren't that big of a deal, though.  I think
 `idstring_peers_xfer_map` might be a suitable shorter name; what do you
 I will put spaces around = operator, and at function params.
 idstring_peers_xfer_map would be right, i was initially using that as a
 global variable (not inside yahoo_data), will correct it. I had initially
 used spaces for indentation, but changed it after datallah's comment. I
 would be glad if you could suggest more changes.

Ticket URL: <http://developer.pidgin.im/ticket/4533#comment:31>
Pidgin <http://pidgin.im>

More information about the Tracker mailing list