[Pidgin] #4533: file transfer support for yahoo

Pidgin trac at pidgin.im
Sun Jan 6 00:11:33 EST 2008


#4533: file transfer support for yahoo
------------------------+---------------------------------------------------
  Reporter:  madthanu   |       Owner:               
      Type:  patch      |      Status:  new          
  Priority:  minor      |   Milestone:               
 Component:  libpurple  |     Version:  2.3.1        
Resolution:             |    Keywords:  file transfer
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by rekkanoryo):

 Replying to [comment:35 madthanu]:
 > Replying to [comment:34 rekkanoryo]:
 > > Shouldn't the "sssss" now read "ssssss" to indicate six strings
 instead of the 5 that existed prior to your patch?
 > yes, it should, thanks for discovering that. I have never seen that part
 of the code executed.
 [[BR]]
 This is exactly the type of thing developer review is supposed to catch.
 :)

 Whenever you're ready, I'd love to see an updated patch for testing.
 Current development code has the patch from #708 applied.  I haven't
 personally looked at that patch in detail.  I'm betting this might be an
 issue if I just blindly apply the patch?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4533#comment:36>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list