[Pidgin] #4530: GSSAPI auth fails with connect server specified

[Pidgin]

#4530: GSSAPI auth fails with connect server specified
--------------------+-------------------------------------------------------
Reporter:  ghudson  |       Owner:  nwalp
    Type:  defect   |      Status:  new  
Priority:  minor    |   Component:  XMPP 
 Version:  2.3.1    |    Keywords:       
 Pending:  0        |  
--------------------+-------------------------------------------------------
 I'll go right to the code problem since most Pidgin developers don't have
 a GSSAPI test setup anyway.  In libpurple/protocols/jabber/jabber.c,
 jabber_login, this line:
 [[[
                 if(connect_server[0]) {
                         jabber_login_connect(js, js->user->domain,
 connect_server, purple_account_get_int(account, "port", 5222));
 ]]]
 uses the XMPP domain as the FQDN when a connect server is specified.  This
 causes GSSAPI with krb5 to use host/xmppdomain as the service name,
 instead of host/servername.  If you use SRV resolution, the returned
 hostname is used as the FQDN instead, and GSSAPI auth works.

 There is a similar problem in jabber_register_account.  I'm not actually
 sure why jabber_login_connect() has four arguments; it should just take
 three arguments and save the host as the FQDN.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4530>
Pidgin <http://pidgin.im>
Pidgin