[Pidgin] #3553: Code duplication reduction in gtkblist.c
Pidgin
trac at pidgin.im
Thu Jan 3 18:55:22 EST 2008
#3553: Code duplication reduction in gtkblist.c
---------------------------+------------------------------------------------
Reporter: nix_nix | Owner:
Type: patch | Status: new
Priority: minor | Milestone:
Component: pidgin (gtk) | Version: 2.2.1
Resolution: | Keywords:
Pending: 0 |
---------------------------+------------------------------------------------
Comment (by nix_nix):
So, as per ticket #4558, I have modified gtkblist.c to use the API
introduced therein. The new patch (dependent, of course, on the API from
#4558) is about to be attached. However, I don't think that both patches
will apply cleanly, because they both modify gtkblist.c in different ways.
I guess the best bet is to grab the branches from idefix.go-nix.ca:
org.maemo.garage.pidgin.pidgin.gtkblist-request-code-dup
contains the modifications required to remove code duplication solely from
gtkblist.c.
org.maemo.garage.pidgin.pidgin.gtkblist-request-code-dup.post-add-widget-
util
Also contains modifications solely to gtkblist.c, but it assumes that the
patch from #4558 is already present.
I'll attach an image illustrating the relationship of the branches (to
#4558 as well).
--
Ticket URL: <http://developer.pidgin.im/ticket/3553#comment:5>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list