[Pidgin] #4508: Custom Icons (XStatuses) support in ICQ

Pidgin trac at pidgin.im
Fri Jan 4 11:27:06 EST 2008


#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                 
  Priority:  minor     |   Milestone:                           
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Changes (by MarkDoliner):

  * status:  new => assigned

Comment:

 This looks pretty good to me.  I'm a little concerned that you keep track
 of which icon the person is using by storing the offset into the
 aim_custom_icons array.  Would it be possible to store the filename,
 instead?  Or, the part of the filename without the underscore?  So,
 "shopping," for example?

 And the filenames... is there any reason they start with an underscore?
 It seems like it would be much more descriptive to call them
 "xstatus_shopping.png" or something.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:1>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list