[Pidgin] #4533: file transfer support for yahoo
Pidgin
trac at pidgin.im
Sat Jan 5 21:52:14 EST 2008
#4533: file transfer support for yahoo
------------------------+---------------------------------------------------
Reporter: madthanu | Owner:
Type: patch | Status: new
Priority: minor | Milestone:
Component: libpurple | Version: 2.3.1
Resolution: | Keywords: file transfer
Pending: 0 |
------------------------+---------------------------------------------------
Comment (by rekkanoryo):
Generally, we use tab indents instead of spaces (although I would
personally prefer a four-space indent over tabs). I didn't look closely
enough to see if that's an issue in your patch. It's also easier to read
patches and the resulting code if assignments have spaces around the =
operator, like so:
{{{
#!c
GList *bar = NULL;
}}}
Meaningful variable names are also great, but long names can be a pain at
times (`yahoo_xfer_idstring_between_peers_xfer_map`, for example). They
generally aren't that big of a deal, though. I think
`idstring_peers_xfer_map` might be a suitable shorter name; what do you
think?
--
Ticket URL: <http://developer.pidgin.im/ticket/4533#comment:30>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list