[Pidgin] #4533: file transfer support for yahoo

[Pidgin]

#4533: file transfer support for yahoo
------------------------+---------------------------------------------------
  Reporter:  madthanu   |       Owner:               
      Type:  patch      |      Status:  new          
  Priority:  minor      |   Milestone:               
 Component:  libpurple  |     Version:  2.3.1        
Resolution:             |    Keywords:  file transfer
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by madthanu):

 Replying to [comment:32 rekkanoryo]:
 > I'm looking over your patch now.  So far, I see one thing I would
 change:
 >
 > {{{
 > #!c
 >         if(yf) if(yf->version_id>500000) ver=15; /* determines whether
 client uses ymsg 15 i.e. client is higher than YM 7 */
 > }}}
 >
 > [[BR]]
 > I would change it to something like this:
 > {{{
 > #!c
 >         /* is the other client using protocol version 15? */
 >         if(yf && yf->version_id > 500000)
 >                 ver = 15;
 > }}}
 >
 > You can get away with this because if `yf` is NULL, the check will
 short-circuit there and the condition will be false.  This makes the
 conditions easier to read, and splitting it into two lines makes the code
 easier to read and understand.
 >
 > I will continue to review and make additional suggestions.
 ok, will change this too

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4533#comment:33>
Pidgin <http://pidgin.im>
Pidgin