[Pidgin] #6242: Clean up win32 make warnings

Pidgin trac at pidgin.im
Sat Jul 19 18:35:57 EDT 2008

#6242: Clean up win32 make warnings
  Reporter:  phroggie         |       Owner:  datallah            
      Type:  patch            |      Status:  new                 
  Priority:  minor            |   Milestone:                      
 Component:  winpidgin (gtk)  |     Version:  2.4.3               
Resolution:                   |    Keywords:  win32 build cleanups
   Pending:  0                |  
Comment (by phroggie):

 Replying to [comment:1 datallah]:
 > In win32-cleanup.diff, including win32dep.h in giowin32.c will cause
 behavior changes - instead of the direct native socket calls, the versions
 in libc_interface.c will be used.  I'm not sure what effect, if any, that
 would have, but it is certainly not an improvement.

 You're right. I saw the warning, and grepped to see which header declared
 that function, and #included it. I'll update the patch to declare
 wpurple_g_io_channel_win32_new_socket directly in giowin32.c.

 > Similarly, the change to libc_interface.c would cause a similar issue
 (I'm not sure how that would even would, because it'd be a recursive

 I don't see any such problem with this block, but I'll take your word for
 it. The bug you're pointing out could be mitigated by leaving
 libc_interface.c alone, and instead moving the declaration of
 wpurple_get_timezone_abbreviation from libc_interface.h to
 libc_internal.h, as libc_interface.h #includes libc_internal.h. Would this
 function be better off defined in util.c, or win32dep.[c|h] instead? A
 quick grep shows it's only referenced once, in util.c.

 Uploading a [attachment:win32-cleanup.v2.diff revised patch].

Ticket URL: <http://developer.pidgin.im/ticket/6242#comment:2>
Pidgin <http://pidgin.im>

More information about the Tracker mailing list