[Pidgin] #6031: ASCII control characters cause problems with libpurple clients

[Pidgin]

#6031: ASCII control characters cause problems with libpurple clients
---------------------+------------------------------------------------------
  Reporter:  dhawes  |       Owner:  deryni
      Type:  defect  |      Status:  closed
  Priority:  minor   |   Milestone:        
 Component:  XMPP    |     Version:  2.4.2 
Resolution:  fixed   |    Keywords:        
   Pending:  0       |  
---------------------+------------------------------------------------------
Comment (by dhawes):

 Applying the patch at
 http://trac.adiumx.com/browser/branches/adium-1.2/Utilities/dep-build-
 scripts/libpurple_jabber_parser_error_handler.diff?rev=24245&format=txt to
 Pidgin 2.4.3 does not fix the issue for me.

 After I send a control character to the chat room, I am still unable to
 see any messages, although I can see them in the Send and Recv debug
 messages.  Also, after the control character has been sent, the second
 message received from the server will result in an XML_ERR_DOCUMENT_END,
 and the account will immediately get disconnected.

 Correct me if I'm wrong, but the desired action here is to ignore the
 control characters and not to disconnect, right?

 I modified the patch to effectively "eat" the invalid chars like in my
 patch above, and it seems to work like I think it should (and errors are
 checked, so hopefully no possibility of infinite loops).  Again, I'm not
 sure how proper that is, but it certainly takes care of the problem.

 I have not tested the patch with the Adium version string issue yet.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/6031#comment:9>
Pidgin <http://pidgin.im>
Pidgin