[Pidgin] #4956: massive QQ_CMD_GET_FRIENDS_ONLINE making pidgin slow

[Pidgin]

#4956: massive QQ_CMD_GET_FRIENDS_ONLINE making pidgin slow
--------------------+-------------------------------------------------------
  Reporter:  moo    |       Owner:  csyfek        
      Type:  patch  |      Status:  closed        
  Priority:  minor  |   Milestone:                
 Component:  QQ     |     Version:  2.3.1         
Resolution:  fixed  |    Keywords:  QQ get friends
   Pending:  0      |  
--------------------+-------------------------------------------------------
Comment (by moo):

 pls read pidgin-bug-4956-fix.diff carefully and double check how you
 applied it. this bug is NOT fixed

 actual code in 2.5.0 repo:
 {{{

     if (position != QQ_FRIENDS_ONLINE_POSITION_END) {
         purple_debug(PURPLE_DEBUG_INFO, "QQ", "Received %d online buddies,
 nextposition=%u\n",
                                 count, (guint) position);
         if (position != QQ_FRIENDS_ONLINE_POSITION_START) {
             purple_debug(PURPLE_DEBUG_INFO, "QQ", "Requesting for more
 online buddies\n");
         }
         qq_send_packet_get_buddies_online(gc, position);
     } else {
         purple_debug(PURPLE_DEBUG_INFO, "QQ", "All online buddies
 received\n");
         qq_send_packet_get_buddies_levels(gc);
         qq_refresh_all_buddy_status(gc);
     }
 }}}

 expected code:
 {{{
     purple_debug(PURPLE_DEBUG_INFO, "QQ", "Received %d online buddies,
 nextposition=%u\n",
                                 count, (guint) position);
     if (position != QQ_FRIENDS_ONLINE_POSITION_END && position !=
 QQ_FRIENDS_ONLINE_POSITION_START) {
         purple_debug(PURPLE_DEBUG_INFO, "QQ", "Requesting for more online
 buddies\n");
         qq_send_packet_get_buddies_online(gc, position);
     } else {
         purple_debug(PURPLE_DEBUG_INFO, "QQ", "All online buddies
 received\n");
         qq_send_packet_get_buddies_levels(gc);
         qq_refresh_all_buddy_status(gc);
     }
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4956#comment:8>
Pidgin <http://pidgin.im>
Pidgin