[Pidgin] #6302: libpurple doesn't download msn display pictures at login ...

[Pidgin]

#6302: libpurple doesn't download msn display pictures at login ...
-----------------------+----------------------------------------------------
Reporter:  visionkrew  |       Owner:  khc                                   
    Type:  defect      |      Status:  new                                   
Priority:  minor       |   Component:  MSN                                   
 Version:              |    Keywords:  msn,missing,display,picture,buddy,icon
 Pending:  0           |  
-----------------------+----------------------------------------------------
 I use Adium with libpurple built from a fresh checkout from the
 im.pidgin.cpw.qulogic.msn branch (revision:
 e0c15c710af77a687e1adb624fdf03917bfef2fe). My findings are:

 1. When you sign in to MSN (so you were offline before), libpurple doesn't
 download your online buddies' current display pictures. The cached DPs
 will be shown, if they exist (if some of your buddies changed DPs while
 you were offline, you won't receive those updated DPs - you'll see the
 cached (and possibly outdated) ones.

 2. If your online buddies change DPs while you are online, you will
 receive the updated DPs almost instantly.

 3. If you are online and one of your buddies signs in (who was offline
 before), you will receive his/her actual DP almost instantly.

 When signing in (so it would be time for libpurple to fetch the online
 users' DPs), Console log shows:

 Jul 12 01:27:24 xyz [0x0-0x6a86a8].com.adiumX.adiumX[31904]: **
 (process:31904): CRITICAL **: purple_signal_emit_vargs: assertion
 `instance_data != NULL' failed[[BR]]
 Jul 12 01:27:30: --- last message repeated 66 times ---[[BR]]
 Jul 12 01:27:30 xyz [0x0-0x6a86a8].com.adiumX.adiumX[31904]: SocketRead:
 read(5) error 0[[BR]]
 Jul 12 01:27:30 xyz [0x0-0x6a86a8].com.adiumX.adiumX[31904]: SocketRead
 err = -9802

 Steps to reproduce the problem:

 1. Quit Adium
 2. Clear the display picture cache (delete ~/Library/Caches/Adium/Default)
 3. Start adium, and sign in to MSN
 4. WAIT - you won't receive your currently online contacts DPs unless they
 sign out and sign in again, or they change DPs.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/6302>
Pidgin <http://pidgin.im>
Pidgin