[Pidgin] #6382: File Transfer is broken in the Yahoo protocol when sending from Pidgin to Pidgin.

[Pidgin]

#6382: File Transfer is broken in the Yahoo protocol when sending from Pidgin to
Pidgin.
-----------------------+----------------------------------------------------
  Reporter:  crhylove  |       Owner:  marv                                      
      Type:  defect    |      Status:  new                                       
  Priority:  minor     |   Milestone:                                            
 Component:  Yahoo!    |     Version:  2.4.3                                     
Resolution:            |    Keywords:  file transfer bug immediate missing dialog
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by sulabh.dev):

 To add more info: On #pidgin, crhylove reports that the user was in his
 friends list, and none of them were using yahoo japan.

 I confirm this defect.

 To reproduce, send a file to a user NOT in friends list.
 There is no YMSG packet sent to yahoo server to report about file transfer
 request, nor its forwarded to the other user. File starts getting
 transferred to some yahoo server, maybe its some old type of file
 transfer.

 In yahoo/yahoo_filexfer.c, yahoo_send_file(), there are some cases when
 ver=15 won't be set, like user not being in friends list or using some old
 messenger, version_id < 500000, in those cases the transfer will fail
 (trying to use some old method ??)

 Fixed by assuming ver=15 for users who aren't friends.
 http://developer.pidgin.im/viewmtn/revision/info/9a753e6b9d2389b3b7a87d60eebbe98228c2fb36

 Since crhylove reports user being in his list, it must be because of
 version_id condition.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/6382#comment:1>
Pidgin <http://pidgin.im>
Pidgin