[Pidgin] #5639: openq 02 patch - fixed multiarch
Pidgin
trac at pidgin.im
Sun Jun 1 03:40:04 EDT 2008
#5639: openq 02 patch - fixed multiarch
---------------------+------------------------------------------------------
Reporter: csyfek | Owner: seanegan
Type: patch | Status: new
Priority: minor | Milestone:
Component: QQ | Version: 2.4.0
Resolution: | Keywords: multiarch patch
Pending: 0 |
---------------------+------------------------------------------------------
Comment (by QuLogic):
Here's a copy of the patch that's not gzipped.
I cleaned it up a little, by removing some excess whitespace changes, and
by converting `/* commented code */` to `#if 0 commented code #endif`. I
made sure it compiled, and fixed up the warnings (those were important!
there were definite problems that needed fixing).
I also changed the `purple_debug` calls in packet_parse.c to be INFO
instead of ERROR, because they certainly are not errors, and I found it
annoying with all that unnecessary red text in my debug window.
The only place I took some extra liberties is with packet_parse.c, where I
removed the commented code, because it was clear that replacement
functions were written and already in use everywhere. There's no use in
leaving the old code around; if you were to need the old code, that's what
MTN is for.
Since I've never been able to login to QQ, someone else will have to check
whether those fixes were correct.
--
Ticket URL: <http://developer.pidgin.im/ticket/5639#comment:2>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list