[Pidgin] #5984: pidgin 2.4.2 with --enable-msnp14 crashes in some condition

Pidgin trac at pidgin.im
Mon Jun 2 02:30:51 EDT 2008


#5984: pidgin 2.4.2 with --enable-msnp14 crashes in some condition
--------------------+-------------------------------------------------------
Reporter:  conwood  |       Owner:  khc
    Type:  patch    |      Status:  new
Priority:  minor    |   Component:  MSN
 Version:  2.4.2    |    Keywords:     
 Pending:  0        |  
--------------------+-------------------------------------------------------
 After pidgin started, when the buddy list is being displayed, it crashed.

 I gdb the core file, found problem maybe in file libpurple/xmlnode.c, in
 function `xmlnode_from_str'.

 In some condition(I didn't figure out when), param str of xmlnode_from_str
 would be `too-large', and this may course xmlnode_from_str return an
 invalid pointer.

 So I add a simple check on param str, if (strncmp(srt, "too-large", 9)==0)
 return NULL;

 And in libpurple/protocols/msn/oim.c, line 478 uses the pointer
 xmlnode_from_str returns, I added a simple check if (node==NULL) return;

 Then I recompiled pidgin, the crash did not happen again.

 Sorry for my poor English if I didn't make it clear, hope the information
 would be helpful.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5984>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list