[Pidgin] #5984: pidgin 2.4.2 with --enable-msnp14 crashes in some condition

[Pidgin]

#5984: pidgin 2.4.2 with --enable-msnp14 crashes in some condition
----------------------+-----------------------------------------------------
  Reporter:  conwood  |       Owner:  khc  
      Type:  patch    |      Status:  new  
  Priority:  minor    |   Milestone:       
 Component:  MSN      |     Version:  2.4.2
Resolution:           |    Keywords:       
   Pending:  0        |  
----------------------+-----------------------------------------------------
Comment (by conwood):

 Thanks khc.

 I use `pidgin -d > debug.out' to get the debug message, and the crash
 just happenned after the following message.

 And now I believe sometimes param `xmlmsg' in function
 `msn_parse_oim_msg' in file `libpurple/protocols/msn/oim.c' would be
 "too-large", and that would cause `xmlnode_from_str' return NULL, but
 in `msn_parse_oim_msg' did not check if NULL is returned. That should
 be the reason of crash.

 Debug message:

 NOTE: I changed my contact's email address to ____

 (18:48:30) MSNP14: get payload len:0
 (18:48:30) blist: Updating buddy status for ____ at hotmail.com (MSN)
 (18:48:30) msn: S: NS 000: UBX ____ at hotmail.com 1 118
 (18:48:30) MSNP14: get payload len:118
 (18:48:30) MSNP14: UBX received.
 (18:48:30) MSNP14: msn get PSM
 (18:48:30) msn: msn get CurrentMedia
 (18:48:30) msn: No currentmedia string
 (18:48:30) blist: Updating buddy status for ____ at hotmail.com (MSN)
 (18:48:30) msn: S: NS 000: MSG Hotmail Hotmail 219
 (18:48:30) MSNP14: get payload len:219
 (18:48:30) MSNP14: Processing MSG...
 (18:48:30) msn: S: NS 000: MSG Hotmail Hotmail 205
 (18:48:30) MSNP14: get payload len:205
 (18:48:30) MSNP14: Processing MSG...
 (18:48:30) MSNP14:OIM: too-large
 (18:48:30) xmlnode: Error parsing xml file: Start tag expected, '<' not
 found

 crash just happenned after this message.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5984#comment:2>
Pidgin <http://pidgin.im>
Pidgin