[Pidgin] #5239: Added Yahoo functionality for the proxy bound
Pidgin
trac at pidgin.im
Sun Jun 8 02:47:58 EDT 2008
#5239: Added Yahoo functionality for the proxy bound
------------------------+---------------------------------------------------
Reporter: johnmoody | Owner:
Type: patch | Status: new
Priority: minor | Milestone: Patches Needing Improvement
Component: libpurple | Version: 2.4.0
Resolution: | Keywords: yahoo alias proxy
Pending: 0 |
------------------------+---------------------------------------------------
Changes (by rlaager):
* milestone: => Patches Needing Improvement
Comment:
Replying to [comment:2 datallah]:
> As it is, this can't go in until 3.0.0 as it changes the ABI.
To clarify this... Instead of using a #define to create a macro, you need
to leave the existing *function* in place and have it call the new one.
Then, you'd mark the function as deprecated in ChangeLog.API, mark it with
@deprecated in the Doxygen comment for that function in the header file,
and wrap the definition in the header file with #ifndef
PURPLE_DISABLE_DEPRECATED to get something like this:
{{{
#ifndef PURPLE_DISABLE_DEPRECATED
/**
* Fetches the data from a URL, and passes it to a callback function.
...
* @param data The user data to pass to the callback function.
* @deprecated Use purple_util_fetch_url_request_with_proxy() instead.
*/
PurpleUtilFetchUrlData *purple_util_fetch_url_request(const gchar *url,
...
PurpleUtilFetchUrlCallback callback, gpointer data);
#endif
}}}
There also seem to be a number of spurious whitespace changes in the diff.
Fixing these two issues should be relatively trivial. From there, I don't
know anything about the actual content of this patch.
--
Ticket URL: <http://developer.pidgin.im/ticket/5239#comment:3>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list