[Pidgin] #6020: purple_xfer_get_remote_user should normalize returned user, fixes Adium issue with transfer on new tab

Pidgin trac at pidgin.im
Thu Jun 12 06:55:44 EDT 2008


#6020: purple_xfer_get_remote_user should normalize returned user, fixes Adium
issue with transfer on new tab
------------------------+---------------------------------------------------
  Reporter:  ono        |       Owner:                
      Type:  patch      |      Status:  new           
  Priority:  minor      |   Milestone:                
 Component:  libpurple  |     Version:  2.4.2         
Resolution:             |    Keywords:  file, transfer
   Pending:  0          |  
------------------------+---------------------------------------------------
Comment (by ono):

 Well I think you are right. This is shortsighted solution from me.

 I think only sensible solution would be sligh API change, so maybe a new
 `xfer->user` which is `strdup` of normalized `xfer->who` freed together
 with `xfer`.

 Then `purple_xfer_get_remote_user` should return `xfer->user` (normalized
 `xfer->who`), while NEW `purple_xfer_get_remote_id` should return
 `xfer->who`.

 So my only concern is that IMHO frontend to `libpurple` such as Pidgin or
 Adium shall nevel deal with not normalized values, which are not valid
 user ids. However I'm aftraid this isn't what happens now, I see both in
 Adium & Pidgin calls to `purple_normalize`. Also frontends shall not dig
 into `xfer` structure directly, but they do a lot!

 Anyway this is beyond my patcher abilities here, somebody responsible for
 `libpurple` has to take the decision.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/6020#comment:5>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list