[Pidgin] #4875: MSNP15 does not update tokens correctly.

Pidgin trac at pidgin.im
Sun Jun 15 04:34:49 EDT 2008


#4875: MSNP15 does not update tokens correctly.
----------------------+-----------------------------------------------------
  Reporter:  QuLogic  |       Owner:  khc             
      Type:  patch    |      Status:  new             
  Priority:  minor    |   Milestone:  Activate MSNPV14
 Component:  MSN      |     Version:                  
Resolution:           |    Keywords:                  
   Pending:  0        |  
----------------------+-----------------------------------------------------
Comment (by qulogic at pidgin.im):

 (In [74d8e44ec0c60b1e362ada585e3b24dd17f404bd]):[[BR]]
 Finally got MSN token updating working (I think).

 So it seems after creating the signature, the xmlnode_to_str must have
 added some xmlns attributes which were sent to the server. I thought that
 CanonicalizationMethod stuff the XML specified meant the server would
 normalize everything nicely, but apparently not.

 I added the xmlns to the XML string before creating the signature and
 it looks like things work now. It just needs a full 8-hour test to be
 certain.

 Did a bit of re-factoring to the token response parsing, as well. It
 should now fail the first time something shows up that isn't expected,
 or if something is missing, instead of blindly going forward with half
 the tokens we requested.

 References #4875.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4875#comment:16>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list