[Pidgin] #5565: Should XMPP resource default to the local machine's hostname?

[Pidgin]

#5565: Should XMPP resource default to the local machine's hostname?
---------------------+------------------------------------------------------
  Reporter:  resiak  |       Owner:  deryni  
      Type:  patch   |      Status:  assigned
  Priority:  minor   |   Milestone:          
 Component:  XMPP    |     Version:  2.4.1   
Resolution:          |    Keywords:          
   Pending:  0       |  
---------------------+------------------------------------------------------
Changes (by deryni):

  * status:  new => assigned

Comment:

 Support for resource binding is a MUST in the new proposed text of RFC
 3920 (and was basically always a MUST for clients that wanted to function
 correctly in general) so I feel comfortable assuming that all servers
 support it.

 As to the patch, using an explicit __NONE__ seems like a poor idea to me
 when we could just as easily use an empty or all-whitespace resource for
 that purpose (and is almost entirely self-documenting). pidgin has a
 purple_strreplace function already so there is no need to create a new one
 just for jabber. (Also, on purely nit-picking points, pidgin does not
 allow // style comments.) Other than that the patch looks fine to me, so
 you can either clean those things up yourself or let me do it when I get
 to applying the patch.

 The whole point of using Home, as I explained before, is that it was
 *supposed* to be clearly wrong sometimes and thus spark people to realize
 that they can change it to say whatever they want it to say.

 Support for random numeric resources would be nice, but if that was going
 to happen it would be best for them to be GUIDs at which point we might as
 well leave that up to the server to handle for us (by not sending a
 resource at all).

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5565#comment:10>
Pidgin <http://pidgin.im>
Pidgin