[Pidgin] #6128: Signal "log-displaying" - unability to change text

[Pidgin]

#6128: Signal "log-displaying" - unability to change text
------------------------+---------------------------------------------------
Reporter:  robots       |       Owner:  lschiere      
    Type:  enhancement  |      Status:  new           
Priority:  minor        |   Component:  unclassified  
 Version:  2.4.2        |    Keywords:  log-displaying
 Pending:  0            |  
------------------------+---------------------------------------------------
 I have been looking at the "log-displaying" signal, I wanted to write my
 own plugin to replace some parts of the displayed data.

 When I look at function "log_select_cb" in pidgin/gtklog.c, this function
 reads the log (into local variable), then calls the signal, and afterwards
 displays the data in the gtk widget.
 Now the problem is that there is no way to change the "read" variable,
 thus no way to change the displayed log.

 This Variable could be added to the arguments of the signal handler.
 Changing the prototype of the function from:

 void (*log_displaying)(PidginLogViewer *viewer, PurpleLog *log);

 to something like:

 void (*log_displaying)(PidginLogViewer *viewer, PurpleLog *log, char
 **read);

 I have not seen a plug-in that uses this signal, so this change should not
 have any serious impact :)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/6128>
Pidgin <http://pidgin.im>
Pidgin