[Pidgin] #1187: Send Custom Emoticons in MSN

[Pidgin]

#1187: Send Custom Emoticons in MSN
-----------------------+----------------------------------------------------
  Reporter:  salinasv  |       Owner:  sadrul  
      Type:  patch     |      Status:  assigned
  Priority:  minor     |   Milestone:  2.4.1   
 Component:  MSN       |     Version:  2.0     
Resolution:            |    Keywords:          
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by sadrul):

 The additional fixes I made to the msn patch:
  * Free the 'msg' in msn_send_emoticons
   * do the same in msn_send_attention, which is not part of this patch
  * Free ->obj in _emoticon_destroy
  * Free 'smileys' in _grab_emoticons
  * _unref 'img' in _grab_emoticons
  * removed the following two lines from user.c:msn_user_set_buddy_icon:
 {{{
 +   if(!msnobj)
 +       msn_object_destroy(msnobj);
 }}}
 What are these two lines supposed to do? As it is, it doesn't make any
 sense to me.
  * Set the img using purple_imgstore_new_from_file (new API) in
 got_sessionreq because 'obj->img' isn't set from
 msn_object_new_from_string

 I tried to test the changes made. But I may have missed something. Please
 let me know if the changes made break anything.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1187#comment:120>
Pidgin <http://pidgin.im>
Pidgin