[Pidgin] #2712: Duplicate groups appears

[Pidgin]

#2712: Duplicate groups appears
---------------------+------------------------------------------------------
  Reporter:  rschnz  |       Owner:  MarkDoliner
      Type:  patch   |      Status:  closed     
  Priority:  minor   |   Milestone:  2.4.1      
 Component:  ICQ     |     Version:  2.1.1      
Resolution:  fixed   |    Keywords:             
   Pending:  0       |  
---------------------+------------------------------------------------------
Comment (by linvinus):

 Replying to [comment:33 MarkDoliner]:
 > I chose to apply the patch from revision 3874 instead of this one.  I
 feel that patch will have less impact on other parts of the oscar protocol
 because it doesn't change the oscar_utf8_try_convert() function.  But this
 should be fixed now in the repository.  Sorry it took me so long to do
 something about this bug.


 Sorry i was in Egypt last week and can't enter in to discussion.

 Patch 3874 resolve only boddy list (and group) problem, but not other
 places! it called 15 times in oscar.c!!
 So other places must be patched too. Also i don't understand why function
 called "oscar_utf8_(TRY)_convert" don't check is content already in UTF8?
 Because of that in
 oscar_user_info_convert_and_add_pair or
 purple_icqinfo
 information about icq user in Russian converted twice in to utf8

 The same problem in
 purple_icqalias  and oscar_buddycb_edit_comment

 in purple_ssi_parseaddmod the same patch was added before!

 if (g_utf8_validate(alias, -1, NULL))
         alias_utf8 = g_strdup(alias);
 else
         alias_utf8 = oscar_utf8_try_convert(account, alias);

 Also problem with incorrect codepage appear in field "Status" at About
 dialog, and in authorization dialog.

 I really hope that we find the true!
 Russian Gnome users waiting for normal (gtk) icq client too long.

 Authorization problem
 http://img235.imageshack.us/my.php?image=screenshotbuddylist3xy4.png

 Status problem
 http://img85.imageshack.us/my.php?image=screenshotbuddyinformathk1.png



 Sorry for English.

 this is patch also resolve authorization problem

-- 
Ticket URL: <http://developer.pidgin.im/ticket/2712#comment:36>
Pidgin <http://pidgin.im>
Pidgin