[Pidgin] #555: icq search

Pidgin trac at pidgin.im
Tue Mar 11 03:57:07 EDT 2008


#555: icq search
---------------------+------------------------------------------------------
  Reporter:  shaman  |       Owner:  MarkDoliner
      Type:  patch   |      Status:  new        
  Priority:  minor   |   Milestone:             
 Component:  ICQ     |     Version:  2.0        
Resolution:          |    Keywords:  icq search 
   Pending:  0       |  
---------------------+------------------------------------------------------
Comment (by MarkDoliner):

 Sorry it took me so long to look at this.  I've uploaded a revised version
 of your patch.  These are the changes I made:
  * Wrapped new strings in _() to mark them for translation
  * Changed space indentation to tabs and various other minor formatting
  * Changed // comments to /* */

 There might be a few other things that will need to be changed before this
 is acceptable, but at least this will need to be changed before I'm
 willing to check it in:
  * All request fields should be pre-populated with the user's existing
 info.  And if the user enters an empty string it should clear the field on
 the server.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/555#comment:11>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list