[Pidgin] #5246: Pidgin crashes on network loss when using jabber

[Pidgin]

#5246: Pidgin crashes on network loss when using jabber
-------------------+--------------------------------------------------------
Reporter:  xkahn   |       Owner:  seanegan      
    Type:  defect  |      Status:  new           
Priority:  minor   |   Component:  Google Talk   
 Version:  2.4.0   |    Keywords:  crash, network
 Pending:  0       |  
-------------------+--------------------------------------------------------
 The problem seems to be that if the network is lost when the jabber plugin
 is sending a ping, the pong fails:

 397     static gboolean jabber_pong_timeout(PurpleConnection *gc)
 398     {
 399             JabberStream *js = gc->proto_data;
 400             purple_connection_error_reason(gc,
 PURPLE_CONNECTION_ERROR_NETWORK_ERROR,
 401                                             _("Ping timeout"));
 402             js->keepalive_timeout = -1;
 403             return FALSE;
 404     }
 405

 (gdb) p *gc
 $4 = {prpl = 0x85882a8, flags = 141237008, state = PURPLE_DISCONNECTED,
 account = 0x0, password = 0x0, inpa = 141303624, buddy_chats = 0x0,
   proto_data = 0x0, display_name = 0x0, keepalive = 0, wants_to_die = 0,
 disconnect_timeout = 41, last_received = 141224400}

 so proto_data and thus js is NULL.  The assignment fails with an abort.

 The effect is that every time the network on my laptop bounces, pidgin
 dies.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5246>
Pidgin <http://pidgin.im>
Pidgin