[Pidgin] #5259: msimprpl font size setting reads from "port" instead of "dpi"

Pidgin trac at pidgin.im
Thu Mar 20 00:26:09 EDT 2008


#5259: msimprpl font size setting reads from "port" instead of "dpi"
----------------------+-----------------------------------------------------
  Reporter:  deryni   |       Owner:  jeff  
      Type:  patch    |      Status:  closed
  Priority:  minor    |   Milestone:        
 Component:  MySpace  |     Version:  2.4.0 
Resolution:  fixed    |    Keywords:        
   Pending:  0        |  
----------------------+-----------------------------------------------------
Changes (by jeff):

  * status:  new => closed
  * resolution:  => fixed
  * summary:  Odd code in the myspace plugin. => msimprpl font size setting
              reads from "port" instead of "dpi"

Comment:

 Cool, this could explain #3645.

 MySpace servers allow connecting on various ports. From
 http://imfreedom.org/wiki/index.php/MySpaceIM , at least these ports are
 allowed: 1863,6660,6661,6662,6665,6668,6669,80,443. So if the user
 specified an alternate port, they'll see incorrect font sizes. I verified
 this by connecting to port 6660 and sending an IM to the official client.

 Changed "port" to "dpi" and now the font size is correct no matter what
 port you use.

 Probably the default port, 1863, accidentally lead to roughly-correct font
 sizes, due to rounding. Weird that it even worked, I agree.

 Committed in b018bfb95aeaf0bd6b4cc353965bd3431891dec9.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5259#comment:1>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list