[Pidgin] #5302: Pidgin uses a number of deprecated gtk interfaces
Pidgin
trac at pidgin.im
Mon Mar 24 16:10:27 EDT 2008
#5302: Pidgin uses a number of deprecated gtk interfaces
---------------------------+------------------------------------------------
Reporter: stewb | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: pidgin (gtk) | Version: 2.4.0
Resolution: | Keywords: deprecated
Pending: 1 |
---------------------------+------------------------------------------------
Changes (by seanegan):
* pending: 0 => 1
Comment:
g_path_get_basename allocates memory, so you'll need to add a g_free every
time you call it.
{{{
+ //size = res_query( query, C_IN, T_SRV, (u_char*)&answer, sizeof(
answer));
}}}
{{{
-G_END_DECLS
+#ifdef __cplusplus
+}
+#endif
}}}
Why are these commented out?
There's a lot of good worthwhile stuff in your patch, but also a lot of
assumingly temporary changes (commenting out #includes, and the sort) that
don't make sense.
Also, it's important to us to maintain backward compatibility with GTK+
2.0.0, which is why we don't outright replace things like GtkActionMenu
with GtkComboBox, as much of your patch does. Generally, to fix this, we
either include #if GTK_CHECK_VERSION conditionals, or wrap both interfaces
in internal.h
Why does LSB disable all deprecated functions, anyway?
--
Ticket URL: <http://developer.pidgin.im/ticket/5302#comment:1>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list