[Pidgin] #4508: Custom Icons (XStatuses) support in ICQ

Pidgin trac at pidgin.im
Thu May 1 07:08:54 EDT 2008


#4508: Custom Icons (XStatuses) support in ICQ
-----------------------+----------------------------------------------------
  Reporter:  minstrel  |       Owner:  MarkDoliner              
      Type:  patch     |      Status:  assigned                 
  Priority:  minor     |   Milestone:                           
 Component:  ICQ       |     Version:  2.3.1                    
Resolution:            |    Keywords:  Custom Icon XStatuses ICQ
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by resiak):

 Some remarks on a brief review of !NightFox's patch:

  * There's no point in adding commented-out calls to `purple_debug_*`.
 Either don't add them, or don't comment them out.
  * Please don't use `//` for comments; it's not supported in C89.
 Instead, use `/* */`.
  * A whole bunch of calls to `g_free`, and `return` statements, have been
 commented out.  This really can't be kosher.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4508#comment:30>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list