[Pidgin] #1187: Send Custom Emoticons in MSN

[Pidgin]

#1187: Send Custom Emoticons in MSN
-----------------------+----------------------------------------------------
  Reporter:  salinasv  |       Owner:  sadrul  
      Type:  patch     |      Status:  assigned
  Priority:  minor     |   Milestone:          
 Component:  MSN       |     Version:  2.0     
Resolution:            |    Keywords:          
   Pending:  0         |  
-----------------------+----------------------------------------------------
Comment (by sadrul):

 I can see one leak in there. The following change should fix it:

 {{{
 ============================================================
 --- pidgin/gtkimhtmltoolbar.c   040b48544e6fd9aeef583eb8fab648122017903f
 +++ pidgin/gtkimhtmltoolbar.c   4974500f465b6c7c24cd17a1c5b81e3927442401
 @@ -771,10 +771,9 @@ insert_smiley_cb(GtkWidget *smiley, GtkI
                 while (unique_smileys) {
                         GtkIMHtmlSmiley *smiley = unique_smileys->data;
                         if (!smiley->hidden) {
 -                               fflush(stdout);
                                 ls = sort_smileys(ls, toolbar,
 &max_line_width, smiley->file, smiley->smile);
                         }
 -                       unique_smileys = unique_smileys->next;
 +                       unique_smileys =
 g_slist_delete_link(unique_smileys, unique_smileys);
                 }
                 /* pack buttons of the list */
                 max_line_width = max_line_width / num_lines;

 }}}

 Does the memory usage go down with that change?

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1187#comment:160>
Pidgin <http://pidgin.im>
Pidgin