[Pidgin] #4875: MSNP15 does not update tokens correctly.

[Pidgin]

#4875: MSNP15 does not update tokens correctly.
----------------------+-----------------------------------------------------
  Reporter:  QuLogic  |       Owner:  khc             
      Type:  patch    |      Status:  new             
  Priority:  minor    |   Milestone:  Activate MSNPV14
 Component:  MSN      |     Version:                  
Resolution:           |    Keywords:                  
   Pending:  0        |  
----------------------+-----------------------------------------------------
Comment (by QuLogic):

 I noticed while merging things that datallah added a few calls to
 `msn_soap_message_destroy` in soap2.c. It seems that these cause a double
 free (due to how I've had to rework SOAP calls) and I've had to remove
 them. I'm not yet certain if it still leaks without these calls, though;
 the SOAP code is a complicated thing...

 {{{
 --- libpurple/protocols/msn/soap2.c
 a002af0e9217c841a6ba623442584447e5f888d7
 +++ libpurple/protocols/msn/soap2.c
 9920b0d5c39c780723682813be41cb93fe605b87
 @@ -399,11 +399,8 @@ msn_soap_read_cb(gpointer data, gint fd,
                                 conn->message = NULL;
                                 message->xml = node;

 -                               if (!msn_soap_handle_body(conn, message))
 {
 -                                       msn_soap_message_destroy(message);
 +                               if (!msn_soap_handle_body(conn, message))
                                         return;
 -                               }
 -                               msn_soap_message_destroy(message);
                         }

                         msn_soap_connection_handle_next(conn);
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4875#comment:9>
Pidgin <http://pidgin.im>
Pidgin