[Pidgin] #3550: PurpleLog::time is wrong

Pidgin trac at pidgin.im
Sun May 11 01:14:20 EDT 2008


#3550: PurpleLog::time is wrong
---------------------------+------------------------------------------------
  Reporter:  xpertbg       |       Owner:  rlaager
      Type:  defect        |      Status:  closed 
  Priority:  minor         |   Milestone:  2.4.2  
 Component:  pidgin (gtk)  |     Version:  2.2.1  
Resolution:  fixed         |    Keywords:         
   Pending:  0             |  
---------------------------+------------------------------------------------
Changes (by rlaager at pidgin.im):

  * status:  assigned => closed
  * resolution:  => fixed
  * milestone:  => 2.4.2

Comment:

 (In [5a4aad0264b9a0daceb00f487909a348015ad3ad]):[[BR]]
 Fix purple_str_to_time() to not break the returned value when we have
 given
 it a string with a GMT offset (like a log filename).  We were setting
 tm_isdst to 0 when we knew the offset.  Apparently, mktime() said, "Umm,
 yes, it is DST." and fixed it by shifting the hour.  The fix is to tell
 the C library (by setting tm_isdst to -1) that we're sure of the time, but
 not the DST status.  Hopefully this doesn't break any other code path.
 Fixes #3550

-- 
Ticket URL: <http://developer.pidgin.im/ticket/3550#comment:17>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list