[Pidgin] #3876: Yahoo Messenger messages silently truncated to first 800 characters
Pidgin
trac at pidgin.im
Wed May 14 01:11:10 EDT 2008
#3876: Yahoo Messenger messages silently truncated to first 800 characters
---------------------+------------------------------------------------------
Reporter: dandv | Owner: marv
Type: patch | Status: new
Priority: minor | Milestone:
Component: Yahoo! | Version: 2.2.2
Resolution: | Keywords:
Pending: 0 |
---------------------+------------------------------------------------------
Comment (by rekkanoryo):
I have two comments on this patch:
1. I don't think we should allow sending a message longer than what the
official clients allow. We mimic the official clients as much as
possible; doing something like this just makes it more obvious to the
server that we're not an official client. This should be changed to the
800 character limit the official client imposes.
1. I see you use `strlen()` to determine if the message is too large.
`strlen()` is not multibyte character-safe. Is the limit 800
''characters'' or 800 ''bytes''? Given that the official client limits to
800 characters, I'd imagine the limit is 946 bytes or 800 characters,
whichever is smaller for the specific message string, but I think that
needs some exploration.
--
Ticket URL: <http://developer.pidgin.im/ticket/3876#comment:3>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list