[Pidgin] #5627: Implement custom emoticons on XMPP using XEP 0231

Pidgin trac at pidgin.im
Wed May 14 06:00:50 EDT 2008


#5627: Implement custom emoticons on XMPP using XEP 0231
--------------------------+-------------------------------------------------
  Reporter:  malu         |       Owner:  deryni               
      Type:  enhancement  |      Status:  new                  
  Priority:  minor        |   Milestone:                       
 Component:  XMPP         |     Version:  2.4.1                
Resolution:               |    Keywords:  xmpp custom emoticons
   Pending:  0            |  
--------------------------+-------------------------------------------------
Comment (by malu):

 Replying to [comment:7 phannent]:
 > Hello,
 >
 > I just patched this to the next.minor branch and compiled on windows.
 Due to Glib being version 2.0 rather than 2.8, I had to change line 62 to
 this:
 >
 >
 > {{{
 >       char hostname[256];
 >       int ret;
 >
 >       ret = gethostname(hostname, sizeof(hostname));
 >       hostname[sizeof(hostname) - 1] = '\0';
 >       if (ret < 0 || hostname[0] == '\0') {
 >               purple_debug_warning("irc", "gethostname() failed -- is
 your hostname set?");
 >               strcpy(hostname, "localhost");
 >       }
 >
 >       /* is there some better way to generate a content ID? */
 >       g_snprintf(cid, sizeof(cid), "%s@%s", checksum, hostname);
 > }}}
 >
 > plus it failed to receive at the other end (see that screenshot I am
 going to attach).
 >
 > If anybody wants to try it on windows its here:
 > [http://www.hannent.eu/pidgin/20080513/xmpp/pidgin-2.5.0devel.exe]

 I will take a look at your patch and integrate it with my patch. Maybe a
 gethostname function should be in libpurple?

 Does the empty line happen when both ends have the patch?
 The current Pidgin doesn't handle <img> tags in XHTML-IM. The smileys get
 translated to such tags when sending the message. They are "unpacked" by
 the receiver (and the text is "smileyfied" using the functions available
 in libpurple. (if custom smileys have been turned off the tag will just be
 converted to the corresponding shortcut text (the "alt" attribute).

-- 
Ticket URL: <http://developer.pidgin.im/ticket/5627#comment:8>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list